search

interscript / rababa

Rababa, the diacritization library for Arabic and Hebrew (Abjad scripts in general)
12 stars 1 forks source link

Hebrew & Arabic merge #42

Closed webdev778 closed 2 years ago

webdev778 commented 2 years ago

This is a pull request that properly merges the Arabic and Hebrew implementations.

I recommend anyone working on Rababa to work on this branch or some descendant of this branch to minimize the conflicts.

It may be possible to unify parts of the Hebrew and Arabic implementations somehow, this PR only attempts a basic

The compatibility is broken - it's Rababa::Arabic::Diacritizer now, not Rababa::Diacritizer (a similar class has been added for Hebrew), Interscript will require some kind of change to account for that.

ronaldtse commented 2 years ago

Merging this now when we still can.