Code cleanup (v2) - Githubissues

interscript / rababa

Rababa, the diacritization library for Arabic and Hebrew (Abjad scripts in general)

12 stars 1 forks source link

Code cleanup (v2) #43

Closed webdev778 closed 2 years ago

webdev778 commented 2 years ago

Use standardrb to clean up the style issues (use bundle exec standardrb --fix before committing)
Move constants from {arabic,hebrew}/constants.rb to {arabic,hebrew}.rb
Move CLI related methods to lib/rababa/cli.rb
Add preliminary tests for Hebrew

ronaldtse commented 2 years ago

@webdev778 this refactor is well done and I'm happy with it (more can be done in the future with regards to actual processing, but this is already very good). Please feel free to merge once the tests pass. Thanks!

ronaldtse commented 2 years ago

@webdev778 feel free to merge this but the tests are failing.

ronaldtse commented 2 years ago

Rebased to new main.

ronaldtse commented 2 years ago

Merging first.

ronaldtse commented 2 years ago

@gilgameshjw @webdev778 all pending PRs are merged. Thanks.