intersystems-community / intersystems-servermanager

VS Code helper extension defining connections to InterSystems servers
https://marketplace.visualstudio.com/items?itemName=intersystems-community.servermanager
MIT License
13 stars 12 forks source link

Avoid discarding all session cookies whenever authprovider notifies any session changes #145

Closed gjsjohnmurray closed 2 years ago

gjsjohnmurray commented 2 years ago

https://github.com/intersystems-community/intersystems-servermanager/blob/439862c58e576b3cba5891d32fca3c2c815e7866/src/extension.ts#L66-L74

As things stand we sometimes discard cookies unnecessarily, e.g.

We need to keep track of sessions we use (and get cookies for). Then in our vscode.authentication.onDidChangeSessions handler, check silently for any of our sessions which no longer exist, then drop their cookies only.