intersystems-community / intersystems-servermanager

VS Code helper extension defining connections to InterSystems servers
https://marketplace.visualstudio.com/items?itemName=intersystems-community.servermanager
MIT License
13 stars 12 forks source link

Treat same username on different servers as distinct accounts (fix #194) #197

Closed gjsjohnmurray closed 1 year ago

gjsjohnmurray commented 1 year ago

This PR fixes #194.

Prior to this change, if user 'jdoe' has signed in to servers 'iris-1' and 'iris-2' there would be only one InterSystems Server Credential entry for 'jdoe' in VS Code's Accounts context menu, and using the Sign Out action from its submenu would offer to delete stored 'jdoe' passwords for every server they existed for.

This change means 'jdoe on iris-1' and 'jdoe on iris-2' are treated as separate accounts.

gjsjohnmurray commented 1 year ago

@hsyhhssyy please download the zipped dev VSIX from https://github.com/intersystems-community/intersystems-servermanager/suites/14579768037/artifacts/825807469, unzip it and install it, for example by drag/dropping the extracted VSIX onto Extension view. Then see if account sign-out behaves better.

gjsjohnmurray commented 1 year ago

@isc-bsaviano please try this dev VSIX as a cross-check that the change doesn't break anything. I'll probably wait until we've heard from @hsyhhssyy before merging, in case changes turn out to be necessary.

isc-bsaviano commented 1 year ago

@gjsjohnmurray I just store my passwords in plaintext so I'll defer to the reporter to test this.

hsyhhssyy commented 1 year ago

@gjsjohnmurray I greatly appreciate your help. As I've mentioned in a comment on another issue, I've installed this plugin and it's functioning exactly as I had hoped.

gjsjohnmurray commented 1 year ago

@hsyhhssyy thanks for verifying. This fix is now in the latest beta VSIX at https://github.com/intersystems-community/intersystems-servermanager/releases