search

intersystems-community / vscode-objectscript

InterSystems ObjectScript extension for Visual Studio Code
https://docs.intersystems.com/components/csp/docbook/DocBook.UI.Page.cls?KEY=GVSCO
Other
108 stars 49 forks source link

Update CI #1352

Closed isc-bsaviano closed 6 months ago

isc-bsaviano commented 6 months ago

Do we really need to build on all three platforms? Action coactions/setup-xvfb@v1 hasn't been updated to Node 20, but xvfb is already installed in the latest Ubuntu runners. Also, The Windows build started failing and updating the actions didn't help.

isc-rsingh commented 6 months ago

I haven't looked into what these checks do, but running successfully on Mac and Windows is key -- and marginally Ubuntu (as a proxy for all Linuxes). Are you saying running these checks on all these platforms aren't helping us ensure that?

isc-bsaviano commented 6 months ago

Yes, exactly. This extension is pure JavaScript and therefore is platform independent. Testing on one OS (Ubuntu) is good enough.

gjsjohnmurray commented 6 months ago

@daimor ought to know, but I guess one reason for running the CI on the different platforms is so that the tests happen on them. But seeing as no actual tests have been written yet we're unlikely to be losing anything by reducing the CI to a single platform.

isc-bsaviano commented 6 months ago

Yeah, that's probably the reason Dmitry implemented the CI the way he did.

isc-bsaviano commented 6 months ago

I updated the build CI to only run on Ubuntu. It succeeded, and there are no more deprecation warnings.