search

intersystems-community / vscode-objectscript

InterSystems ObjectScript extension for Visual Studio Code
https://docs.intersystems.com/components/csp/docbook/DocBook.UI.Page.cls?KEY=GVSCO
Other
106 stars 48 forks source link

XML Import/Export commands shouldn't assume a server connection in a multi-root workspace #1387

Closed isc-bsaviano closed 2 months ago

isc-bsaviano commented 2 months ago

This PR addresses some confusing behavior reported by an internal dev. They had a multi-root workspace connected to %SYS and USER on the same server. They had a document from %SYS in the active editor tab, but wanted to import an XML file into USER. The command defaulted to use the %SYS connection, so the file got imported into the wrong namespace. I think it's a better user experience to always ask for the connection if you're in a multi-root workspace.

isc-bsaviano commented 2 months ago

No, the behavior is the same for client-side and server-side workspaces. The only change is that the command won't use the server connection of the active text editor by default.