search

intersystems-community / vscode-objectscript

InterSystems ObjectScript extension for Visual Studio Code
https://docs.intersystems.com/components/csp/docbook/DocBook.UI.Page.cls?KEY=GVSCO
Other
106 stars 48 forks source link

Use default web application for CodeLens links #1393

Closed isc-bsaviano closed 2 months ago

isc-bsaviano commented 2 months ago

This PR fixes #1392. I removed the CSPCHD token fetching code because we should let the browser handle the cookies.

gjsjohnmurray commented 2 months ago

Is the removal of the CSPCHD code necessary? Will it mean that if my external browser isn't already logged in to the server VS Code is working on I will now have to authenticate there to benefit from this VS Code extension feature?

isc-bsaviano commented 2 months ago

I think that adding the parameter doesn't add value because by default the SMP won't use it. IMO it's confusing for the user to see the parameter in the URL but have to log in.