Open isc-bsaviano opened 2 months ago
@gjsjohnmurray @isc-rsingh I've opened this as a draft since this is a giant PR that needs thorough review. I have a few design questions for you that I'd like to resolve before formally starting the review process and seeking feedback from other users:
objectscript.explorer.alwaysShowServerCopy
? Keeping the setting gives users who liked the previous behavior a way to retain it, but is that behavior desirable? I can’t think of a good reason why you’d want the InterSystems Explorer to show the local copies other than “that’s the way it is by default”. objectscript.deleteOnFileDelete
, modeled after objectscript.importOnSave
?@daimor I'd appreciate your feedback on this as a regular client-side editing user.
Is this worth publicizing on DC for feedback before merging?
@isc-rsingh I've already done so: https://community.intersystems.com/post/do-you-use-client-side-editing-vs-code-if-so-we-want-your-feedback
Uri
s as the value, and one in the reverse direction.FileSystemWatcher
to update the index when files are created, deleted or changed on disk and anonDidChangeTextDocument
handler to update the index when a file is changed within VS Code.Uri
for it in a workspace folder was deleted.DocumentContentProvider.getUri()
will use the index to determine theUri
for a class or routine in a non-isfs folder. The export settings are now only used for non-classes and routines in folders with thefile
scheme.WorkspaceSymbolProvider
will only return results from classes that are in the client-side folder by using the index to determine all known classes.objectscript.showExplorer
setting.objectscript.export
settings, except for DFI’s which still check the export settings to preserve the path splitting behavior added by #808. Any file within a workspace folder that has a supported abstract document extension will be imported with the last part of the path used as the server name (except for DFI’s that match the export settings).Add Server Namespace to Workspace…
command if the current workspace already has a client-side folder in it. This is to prevent the blending of client-side and server-side workflows in a way that can lead to lost changes or overwritten edits.objectscript.explorer.alwaysShowServerCopy
setting to true. The InterSystems Explorer should always show the server copy since the local copy can be opened from the files explorer.objectscript.export.noStorage
setting. Storage is an integral part of the class definition, and we shouldn’t allow removing it.objectscript.export.dontExportIfNoChanges
setting. I don’t think that turning it on adds any benefit to the user.