search

intersystems-community / vscode-objectscript

InterSystems ObjectScript extension for Visual Studio Code
https://docs.intersystems.com/components/csp/docbook/DocBook.UI.Page.cls?KEY=GVSCO
Other
106 stars 48 forks source link

Fix showing of CSP files in project folders #1408

Closed isc-bsaviano closed 1 month ago

isc-bsaviano commented 1 month ago

This PR fixes #1406 and fixes #1407

isc-bsaviano commented 1 month ago

@gjsjohnmurray Everything looks fine to me now. Please let me know if you're still seeing issues.

gjsjohnmurray commented 1 month ago

My Show1407 project now expands correctly in Explorer view.

However the second part of my procedure at https://github.com/intersystems-community/vscode-objectscript/issues/1407#issuecomment-2247870473 (creation of New1407 project) still results in an incorrect project definition. The XML export of it looks like this:

<?xml version="1.0" encoding="UTF-8"?>
<Export generator="IRIS" version="26" zv="IRIS for Windows (x86-64) 2024.1 (Build 267_2U)" ts="2024-07-24 15:25:48">
<Project name="New1407" LastModified="2024-07-24 15:23:58">
  <Items>
    <ProjectItem name="show1407" type="PKG"></ProjectItem>
  </Items>
</Project>
</Export>

It seems that the Add Items to Project... step incorrectly creates a ProjectItem of type PKG when I selected the folder named show1407. Notice that the name attribute of the bad ProjectItem is lowercase, which is why our VS Code views fail to expand the classes that are in the Show1407 package.

isc-bsaviano commented 1 month ago

Should be good now