Prevent overprompting for permission and account

intersystems-community / vscode-objectscript

InterSystems ObjectScript extension for Visual Studio Code

https://docs.intersystems.com/components/csp/docbook/DocBook.UI.Page.cls?KEY=GVSCO

Other

108 stars 50 forks source link

Prevent overprompting for permission and account #1456

Closed gjsjohnmurray closed 1 week ago

gjsjohnmurray commented 2 weeks ago

This PR leverages https://github.com/intersystems-community/intersystems-servermanager/pull/243

Requires Server Manager 3.8.0 in order to be effective, but shouldn't break when used with earlier version

a-boertien commented 1 week ago

hi @gjsjohnmurray @isc-bsaviano I think there might be a bug with this... I am being prompted on every file now to authenticate, and I receive this warning on authentication:

After selecting "Keep...", the same warning appears next time. I have also tried signing out of all credentials in VSCode accounts menu.

Versions: server manager 3.8.0, objectscript 2.12.10, VSCode 1.95.2 (windows)

Should I raise a new issue?

isc-bsaviano commented 1 week ago

@a-boertien That's a bug in the Language Server 2.6.4 which is fixed in 2.6.5.

a-boertien commented 1 week ago

Thanks @isc-bsaviano - have just updated to 2.6.5 and it looks resolved!

a-boertien commented 5 days ago

hi @gjsjohnmurray @isc-bsaviano Just wanted to leave some positive feedback. I was a long time sufferer of over prompting -- have not noticed any over the last week, so this is a welcome fix!