'Server Source Control' and 'Server Command Menu' flipped after connecting to different server - Githubissues

intersystems-community / vscode-objectscript

InterSystems ObjectScript extension for Visual Studio Code

https://docs.intersystems.com/components/csp/docbook/DocBook.UI.Page.cls?KEY=GVSCO

Other

108 stars 50 forks source link

'Server Source Control' and 'Server Command Menu' flipped after connecting to different server #1458

Open mbries opened 1 week ago

mbries commented 1 week ago

Working in a client environment with many remote HealthShare instances, I experienced twice in a single day that after switching to a new server, clicking on 'Server Source Control' would actually execute 'Server Command Menu' and vice versa.

Clicking this 'Server Source Control': Results in this prompt:

The HealthShare instances were all 2021.1, and the InterSystems Server Manager version was v3.8.0. The only remedy I have found for this issue is to restart VSCode entirely. Forcing a reconnect to the server in question does not solve the problem.

isc-bsaviano commented 1 week ago

@mbries The Server Actions menu is contributed by the vscode-objectscript extension, so I moved this issue there. What exactly are you doing when you're "switching to a new server"?

mbries commented 1 week ago

Initially I'll have a single remote server added as a folder in a VSCode workspace - DEVUCR for example. VSCode is actively connected to the first server and both selections are working as expected. I then add another remote server - say DEVCV, to my VSCode Workspace. I open a code artifact from the 2nd server, and verify that the active connection is indeed the correct server (DEVCV shows in the connection box in the bottom left corner). Then no matter which way I access either Server Source Control or Server Command Menu I get the flipped behavior: Right clicking on the open document or clicking on the active connection box and choosing it from the center dropdown menu doesn't make any difference.

Edit to add: InterSystems ObjectScript extension is version v2.12.10

isc-bsaviano commented 1 week ago

Thanks for the detailed response. That sounds really strange. I will try to reproduce it.

isc-bsaviano commented 1 week ago

@mbries I wasn't able to reproduce this issue. Here's what I tried:

Opened a workspace folder that contains two isfs folders connected to the same server.
Opened a document in one folder and verified that the source control and server command menus were correct.
Added a third isfs folder using the Add Server Namespace to Workspace... command that is connected to a different server.
Opened a document in the new folder and verified that the source control and server command menus were correct.

isc-bsaviano commented 1 week ago

I think the confusion is caused the the dropdown's prompt message. It always says "Pick server-side command to perform..." even if you selected the source control menu.

isc-bsaviano commented 1 week ago

@mbries Can you confirm that the correct menu options are appearing, even if the prompt is confusing?

mbries commented 1 week ago

@isc-bsaviano when this occurs the correct menu options are not appearing. 'Server Source Control' prompts for a server command, while 'Server Command Menu' prompts for the source control options.

I was doing this exact workflow today and the issue did not re-occur, I will continue to monitor for it so I can determine if there are more contributing factors.

isc-bsaviano commented 1 week ago

Thanks for clarifying @mbries. Is it possible that this is a server issue? I looked at our code in this area and I don't see any places where the menus could get mixed up.

isc-bsaviano commented 6 days ago

Hi @mbries, are you still experiencing this issue? Have you been able to identify if happens with more than one server?