intersystems / git-source-control

Server-side source control hooks for InterSystems' platforms to facilitate use of git, especially in shared and/or remote development environments and for interoperability graphical editors
12 stars 8 forks source link

Slow Production load with set up git #331

Closed SRFTInterface closed 6 months ago

SRFTInterface commented 6 months ago

Recorded in WRC# 986463. Issue is after setting up Git and Azure using SSL key production monitor page slowed down from a <1 second load to a 6-10 second load

isc-tleavitt commented 6 months ago

@SRFTInterface FYI, we have a new release coming very soon (v2.3.1) which addresses some performance issues. I suspect it could fix this too.

isc-tleavitt commented 6 months ago

@SRFTInterface I've just published version 2.3.1 - can you see if that addresses the issue?

SRFTInterface commented 6 months ago

Hi, we have had a few other issues today- initially it looks like it loads up fast. The GIT GUI in tie workspace is not showing changes when add to git- working when using gitextensions on the user running ensemble with the ssh rights image image

isc-tleavitt commented 6 months ago

@SRFTInterface is this after updating to 2.3.1?

SRFTInterface commented 6 months ago

This is when using 2.3.1. The initial load of the production monitor is much improved. Git itself still works using git installed on the server and other git commands work. i think not understanding Add of file shouldn't automatically stage

303 but I tried an Existing item in GIT /Component/Winpath/Functions

image and it isn't either in working copy even though it is in the local and branch image

isc-tleavitt commented 6 months ago

@isc-pbarton can you take a look at this?

SRFTInterface commented 6 months ago

@isc-pbarton to confirm that the array has current user changes if i'm looking at it , i don't know much about .js really but at least means it knows somewhere there are changes to display image

isc-pbarton commented 6 months ago

@SRFTInterface I haven't been able to replicate this so far but will try some more options tomorrow. In the meantime could you try clearing your web browser's cache to see if that makes a difference? Also if you are able to provide detailed steps to replicate the error that would be very helpful.

SRFTInterface commented 6 months ago

I just ZPM installed the new version and on my understanding started to add classes via studio or VS code to the repo. I cleared now that was new to git.Remove() everything from source and still get the new issue. image

SRFTInterface commented 6 months ago

@isc-pbarton tested the old WebUIDriver.cls and realised it worked so looked at the current WebUIDriver.cls I have noticed if i change the line

set fileToOtherDevelopers ={}

to set fileToOtherDevelopers =[] using the 2.3.1 version of git control it works for me This then works. image

Using Windows.
If i revert this back to {} it is where it would fail again.

isc-pbarton commented 6 months ago

@SRFTInterface Thank you for the screenshots. It does like like you have the older version of the Web UI running, and it's conflicting with the newer version of the ObjectScript code. Could you try uninstalling and then reinstalling the package?

zpm
uninstall git-source-control
install git-source-control 2.3.1

Another thing to try might be clearing the CSP gateway cache. set registry = $system.CSP.GetGatewayRegistry() set gateways = registry.GetGatewayMgrs() for no=1:1:gateways.Count() do gateways.GetAt(no).ClearCache()

SRFTInterface commented 6 months ago

Thanks, needed to be disabled first before uninstalling and installed second time via the studio command as is the setup notes. Speed is much much improved