intersystems / git-source-control

Server-side source control hooks for InterSystems' platforms to facilitate use of git, especially in shared and/or remote development environments and for interoperability graphical editors
11 stars 6 forks source link

Add support for IRIS BI #398

Closed evshvarov closed 2 weeks ago

evshvarov commented 3 weeks ago

Recommended solution: Add a default mapping for the DFI extension

Original description from @evshvarov : Currently, dashboards are being exported to an unexpected place - in class packages folders, rather than in /dfi/...

isc-tleavitt commented 3 weeks ago

@evshvarov what are your mapping configurations in the Settings page?

evshvarov commented 3 weeks ago

No settings touched. I just installed the source control

On Mon, Jul 8, 2024 at 12:56 PM Tim Leavitt @.***> wrote:

@evshvarov https://github.com/evshvarov what are your mapping configurations in the Settings page?

— Reply to this email directly, view it on GitHub https://github.com/intersystems/git-source-control/issues/398#issuecomment-2213812220, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVHEP5XNOYTJ4KUVKB7K2LZLJ465AVCNFSM6AAAAABKQSUJWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJTHAYTEMRSGA . You are receiving this because you were mentioned.Message ID: @.***>

isc-tleavitt commented 3 weeks ago

ok - ultimately there just needs to be a default mapping for DFI among the initial/default mapping sets.

isc-pbarton commented 2 weeks ago

We should still add that default mapping, but I connected with Evgeny to see that this is an issue in an IPM package where the mappings should not be relevant.

Replicate by:

This might be just a configuration tweak required in the module.xml of that iris-analytics-template so git-source-control knows where to export the DFI.

isc-tleavitt commented 2 weeks ago

This is most likely an issue with module.xml - the resource(s) need Directory="dfi"; IPM is permissive about where it'll look for things to install/load and doesn't enforce a strict mapping.

evshvarov commented 2 weeks ago

@isc-tleavitt tried Directory="dfi" and didn't work from scratch. Could you please suggest a PR to https://github.com/intersystems-community/iris-analytics-template/blob/master/module.xml ?

isc-pbarton commented 2 weeks ago

@evshvarov I made a PR here to add the Directory="dfi". The export was working for me once I reloaded the new module.xml. https://github.com/intersystems-community/iris-analytics-template/pull/7

evshvarov commented 2 weeks ago

Thank you, @isc-pbarton ! Indeed this helped! It doesn't work for pivots though (as there is no git-source-control in Analyzer I guess).

evshvarov commented 2 weeks ago

I'll close this one anyway as this problem solved

isc-pbarton commented 2 weeks ago

I created a separate issue #428 to capture the improvement suggested in Tim's comment