Error (hspm) If during the installation of a module with dependencies an error occurred and the module was not installed, then the dependent modules should not be installed either.

intersystems / ipm

InterSystems ObjectScript Package Manager

MIT License

27 stars 19 forks source link

Error (hspm) If during the installation of a module with dependencies an error occurred and the module was not installed, then the dependent modules should not be installed either. #240

Closed SergeyMi37 closed 3 years ago

SergeyMi37 commented 3 years ago

If during the installation of a module with dependencies an error occurred and the module was not installed, then the dependent modules should not be installed either.

Previously, this was solved by rolling back the transaction.

evshvarov commented 3 years ago

We don't use transactions anymore?

On Tue, Jul 20, 2021 at 8:15 AM Sergey Mikhaylenko @.***> wrote:

If during the installation of a module with dependencies an error occurred and the module was not installed, then the dependent modules should not be installed either.

Previously, this was solved by rolling back the transaction.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/intersystems-community/zpm/issues/240, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVHEPZK2F3CWM3BPKBDXL3TYUA7FANCNFSM5AVA2C2Q .

daimor commented 3 years ago

We still have transactions, but they should not be so wide. Dependent modules should not be reverted if they were successfully installed.

evshvarov commented 3 years ago

In fact, I'm OK with that - the building process more and more goes to container-based where you don't care very much about what is installed - you jut rebuild it.

On Tue, Jul 20, 2021 at 9:05 AM Dmitry Maslennikov @.***> wrote:

We still have transactions, but they should not be so wide. Dependent modules should not be reverted if they were successfully installed.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/intersystems-community/zpm/issues/240#issuecomment-883096891, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVHEP4WEGXJPPF7UCRDETTTYUGZPANCNFSM5AVA2C2Q .

daimor commented 3 years ago

transactions supposed to be as small as possible, to cover just only what needs to be covered, then commit or rollback. too big transactions may cause issues, for instance, if a module has many dependencies.

evshvarov commented 3 years ago

makes sense

On Tue, Jul 20, 2021 at 9:10 AM Dmitry Maslennikov @.***> wrote:

transactions supposed to be as small as possible, to cover just only what needs to be covered, then commit or rollback. too big transactions may cause issues, for instance, if a module has many dependencies.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/intersystems-community/zpm/issues/240#issuecomment-883101121, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVHEP3YORQGGAUIBVYXJBLTYUHOTANCNFSM5AVA2C2Q .

SergeyMi37 commented 3 years ago