intersystems / ipm

InterSystems ObjectScript Package Manager
MIT License
28 stars 19 forks source link

Incorect "*.DFI" export/import support #473

Open Frisle opened 2 months ago

Frisle commented 2 months ago

Not only that syntax is malfunctioned, but all ways of importing/exporting dfi files

All this is not working properly https://github.com/intersystems/ipm/pull/169

For example

When upload Code_dEAEL7ooT7

When download and install into another app Code_pelJyjfLwp

When using Resourse Name="*.DFI"

Code_X4YqBaUfv4

isc-tleavitt commented 2 months ago

We really shouldn't declare / allow *.DFI because that says "the current package owns all DFIs in the current namespace" - meaning, if the package is uninstalled, all DFIs should be deleted to clean up. The solution to this is covered in #381.

The other issue, looking for .dfi but not .xml, is incidentally covered in work that will be part of v0.9.0 (the next major release - targeting next month for that). The changes in #466 fix this (and our integration tests properly cover it).

Will leave this open until v0.9.0 is released (that's the point at which it's really "fixed" for your purposes).