Open isc-tleavitt opened 2 months ago
Latest run with all the v1 fixes (https://github.com/intersystems/ipm/actions/runs/8899744512) shows all the FileCopy cases to be fixed, all the other cases still present.
Update: I've figured out the reason for zpmhub to fail. This is also caused by %ZPM -> IPM package rename. See https://github.com/banksiaglobal/zpmhub/blob/00ba0598fffe7bdbe03277dbd90c8ea700cdbb09/src/ZPMHUB/Setup.cls#L25
Additionally, interoperability-for-money fails because of this line https://github.com/oliverwilms/interoperability-for-money/blob/074bb6bca3712b3a0e0bc7eba379244bc77d4d16/module.xml#L20.
As for appmsw-forbid-old-passwd, it's likely that the module.xml is not properly parsed to get the src/mac/PASSWORD.mac
file. Instead, it's trying to find the src/PASSWORD.xml
file.
I have opened PRs for zpm-generate-ui, zpmhub, zapm, zapm-editor.
The installation error will be fixed in zapm-addcmd once PR for zapm is merged.
As for interoperability-for-money, we have concluded that it never should have worked in v0.7 because of a naming conflict (%dbrole).
Finally, fixes for run-container-command-execution and appmsw-forbid-old-passwd have been merged into the v1 branch.
Discussed today: we need to expand the packages CI workflow to cover all packages, which involves some rearchitecture. I'll file a separate issue for that.
Found more cases of lifecycle class dependency (which motivated the expansion) - there are enough of these, and we don't want to require new releases of the packages involved. Strategy will be:
This is a little messy but ultimately less work will be required and it's better for backward compatibility.
Reviewing https://github.com/intersystems/ipm/actions/runs/8879408830 vs. baseline https://github.com/intersystems/ipm/actions/runs/8883338832 - install + test all packages with 4 or more released versions
Non-lifecycle dependencies - these are cases where the class rename has caused issues:
Lifecycle parent class dependencies:
Other really random cases (possible IPM regressions):