interuss / dss

InterUSS Platform's implementation of the ASTM DSS concept for RID and flight coordination.
Apache License 2.0
124 stars 90 forks source link

Grid UVR needs to be in sync with NASA's UVR model on v4-draft #67

Closed myspri closed 5 years ago

myspri commented 5 years ago

@BenjaminPelletier, we have updated UVR model https://github.com/nasa/utm-apis/blob/v4-draft/utm-domains/utm-domain-commons.yaml

This is usually announced in the uss_implementor's channel. Going forward, we will give you advance notice that will allow our models to be in sync before the announcement goes out.

Can you please update your model based on this?

We have been trying to codegen from your version and have encountered a problem with "allOf" attribute. We are currently blocked. I believe the v4-draft does not include this attribute.

Hopefully, this problem will go away after you sync up with our version.

To Reproduce Steps to reproduce the behavior: Unable to codegen from the current Grid UVR model

Expected behavior Should be able to codegen from Grid UVR model

Additional context Add any other context about the problem here.

BenjaminPelletier commented 5 years ago

There are 3 things that need to be addressed: 1) Incorporate required_support 2) Make type required 3) Remove allOf: attributes because swagger-codegen can't handle them. This will hide the documentation for these fields on the SwaggerHub page, but that is necessary to get the codegen to work.