class FetchedSubscription(fetch.Query) currently considers receiving a 404 from the DSS a success (ie, the success property will return True).
This is not strictly correct and can lead to confusion: a 404 will now cause success to be false. Callers that need to differentiate between a failure and a 404 may use was_not_found which will only be true if the returned code was 404.
class FetchedSubscription(fetch.Query)
currently considers receiving a 404 from the DSS a success (ie, thesuccess
property will return True).This is not strictly correct and can lead to confusion: a 404 will now cause
success
to be false. Callers that need to differentiate between a failure and a 404 may usewas_not_found
which will only be true if the returned code was 404.Split out of #720