intesys / ytestbook

Manage test planning, execution and report
1 stars 0 forks source link

Comments entity should include a reference to a collaborator #77

Closed kino90 closed 1 week ago

kino90 commented 2 weeks ago

ATM Comments type is

export type TCommentDynamicData = {
  username: string;
  content: string;
};

export type TComment = {
  id: string;
  caseId: TCase["id"];
  testId?: TTest["id"];
  stepId?: TStep["id"];
  createdAt: number;
  testStatusWhenCreated?: StatusEnum;
  resolved: boolean;
} & TCommentDynamicData;

This way we cannot easily use the Avatars component to show the user's Avatar (in comments list, for example).

We could change it into something like :

export type TCommentDynamicData = {
  collaboratorId: string;
  content: string;
};
nicolabosco87 commented 1 week ago

related PR https://github.com/intesys/ytestbook/pull/84