Grammar mistakes - Githubissues

intika / Librefox

Librefox: Firefox with privacy enhancements

https://librefox.org

Mozilla Public License 2.0

1.72k stars 89 forks source link

Grammar mistakes #11

Closed mikroskeem closed 5 years ago

mikroskeem commented 5 years ago

This makes project unappealing for new users. Just saying :smile:

mikroskeem commented 5 years ago

Some examples:

This project aim to fix privacy and security issues related to firefox without loosing performances nor forking the project.
performances settings
Additional filter are available
usefull for performance
official firefox set for a better privacy, security and performances // what?

etc.

intika commented 5 years ago

Thank you for the feedback it's appreciated... v2 is taking me a lot of time... i just get it done locally today... it will be published today or tomorrow... English is not my first language i am trying the best i can to make the readme as correct as possible, half of what you cited is already corrected in my local version, i will indeed correct what's remaining from your list.

If you have a little time it would be appreciated if you report back other mistakes once v2 will be published.

Thanks a lot for your contribution.

Note : i will let you know here when i publish the last version

intika commented 5 years ago

I changed official firefox set for a better privacy, security and performances to official firefox with a better privacy, security and performances can you please develop what was the mistake ?

mikroskeem commented 5 years ago

You're welcome, I'll take a look at v2 once it's released and when I have time. :smile:

what was the mistake ?

In my opinion (and few others) given sentence was badly worded and hard to understand.

brainscar commented 5 years ago

Github is malfunctioning on my computer, so I put some spelling changes here:

https://www.diffchecker.com/EqeYzO6D

mikroskeem commented 5 years ago

@brainscar can you provide that diff somewhere so one could apply it using e.g git apply?

brainscar commented 5 years ago

👍

https://github.com/brainscar/Librefox-Firefox/blob/master/README.md

intika commented 5 years ago

Woups i already applied the changes... it does a matter i will PR your version any way :) :+1:

intika commented 5 years ago

Changes have been done, closing this. thanks you a lot for your contribution

intika commented 5 years ago

i pushed the so called v2... if you have the time check the readme that would be awesome... thanks again !