search

intika / Librefox

Librefox: Firefox with privacy enhancements
https://librefox.org
Mozilla Public License 2.0
1.72k stars 89 forks source link

Move XPIs to release section #116

Open KOLANICH opened 5 years ago

KOLANICH commented 5 years ago

1 You will need to rewrite history (there is an app for that), otherwise the wasted space won't be reclaimed. 2 It is not a good idea to store xpis in the repo at all.

intika commented 5 years ago

I will move them to release section later on ;) They will be moved from there anyway

KOLANICH commented 5 years ago

IMHO XPIs should be installed from the files provided by their authors, not the ones stored separately. Extensions are separate products, let's not mix them with the browser. They can be installed by default, but they should be installed not from bundled xpis, but from the ones supplied by their authors. In other words, when a browser creates a new profile, it should ask its user if a user needs the default adddons to be installed, and if the user approves, then the browser should download and install them. Or it may show not a confirm, but a window with checkboxes, one for an addon, all selected by default, and for each addon a description why it was decided to add it into the recommended bundle.

intika commented 5 years ago

Those xpi versions are reviewed, it's why i made a copy there (a reviewed version, code check/review) newer version may add unwanted behavior... but yes this should even be on a different repo/release-section with a similar solution to the one you exposed ;)

KOLANICH commented 5 years ago

Those xpi versions are reviewed

It is good they are reviewed, but you can store only their locations and hashes.