intika / Librefox

Librefox: Firefox with privacy enhancements
https://librefox.org
Mozilla Public License 2.0
1.71k stars 91 forks source link

Nohttp script are not case sensitive #66

Closed intika closed 5 years ago

intika commented 5 years ago
> "hTTp://www.reddit.com/r/firefox/comments/a93629/librefox_firefox_with_privacy_enhancements_ghacks/eckgwo4/?context=5".replace(/^http:/,"https:")
"hTTp://www.reddit.com/r/firefox/comments/a93629/librefox_firefox_with_privacy_enhancements_ghacks/eckgwo4/?context=5"
> "http://www.reddit.com/r/firefox/comments/a93629/librefox_firefox_with_privacy_enhancements_ghacks/eckgwo4/?context=5".replace(/^http:/,"https:")
"https://www.reddit.com/r/firefox/comments/a93629/librefox_firefox_with_privacy_enhancements_ghacks/eckgwo4/?context=5"
atbanpc commented 5 years ago

I've tried to reproduce this behavior but it seems that Firefox corrects the capitalized 'http' to lowercase. Are there any examples of actions that result in this behavior?

On another note, to change this, we would need to fork the extension.

intika commented 5 years ago

@atbanpc thank you very much for your feedback indeed Firefox correct the case, this issue was reported back from a reddit user but i did not had the time to verify it (i did now), this issue is irrelevant.

And yes indeed to fix this, the extension would need to be forked (i opened this because i am willing to integrate a part of this script to the Librefox's future main extension)

Thanks you very much for checking and reporting back this ;)