intjelic / python-sfml

Official binding of SFML for Python
https://www.python-sfml.org
Other
176 stars 41 forks source link

Creating sprites without a texture crashes python #145

Open tgrajewski opened 7 years ago

tgrajewski commented 7 years ago

This line crashes python:

sprite = sf.Sprite(None)

Would be great if at least an exception could be thrown here. And even better would be if a non-renderable sprite would be created with a possibility of setting a texture later in code.

intjelic commented 7 years ago

You're right andd actually I'm aware of that, I'll look into that soon!

Necklaces commented 7 years ago

To me it looks like it's cythons fault somehow, I mean this works and correctly raises an error:

>>> from sfml import sf
>>> sf.Sprite(False)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: Argument 'texture' has incorrect type (expected sfml.graphics.Texture, got bool)

But None just straight out segfaults it..

>>> sf.Sprite(None)
Segmentation fault (core dumped)