Replace `mergeDeep` with `deepCopy` from `@intlify/shared` - Githubissues

intlify / bundle-tools

bundling for intlify i18n tools

MIT License

244 stars 37 forks source link

Replace `mergeDeep` with `deepCopy` from `@intlify/shared` #399

Open BobbieGoede opened 2 months ago

BobbieGoede commented 2 months ago

Reporting a bug?

I might be mistaken but the mergeDeep function looks similar to (maybe an older version of) the deepCopy function exported by @intlify/shared. Replacing it should make it easier to maintain across packages and possibly prevent issues that we have already solved (such as https://github.com/intlify/vue-i18n/pull/1947).

Expected behavior

-

Reproduction

-

Issue Package

unplugin-vue-i18n

System Info

Screenshot

No response

Additional context

No response

Validations

[X] Read the Contributing Guidelines.
[X] Read the README
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.

BobbieGoede commented 2 months ago

This isn't really a bug (not sure if people are experiencing with deep copy in this plugin) but more of a maintenance issue, I haven't tried reproducing previously found deepCopy issues using the code here.