search

intlify / vue-i18n-jest

:globe_with_meridians: vue-jest wrapper for i18n custom blocks
MIT License
7 stars 4 forks source link

Accept new versions of vue-jest for vue 2 #38

Closed afontcu closed 3 years ago

afontcu commented 3 years ago

Hi! vue-jest 4.0.1 has been released, and the current peerDep definition of -beta.3 does not include this patch version.

Also, @vue/vue2-jest has been released, and I think the following versions should be supported, too: ^27.0.0 || ^27.0.0-alpha.

I was about to open a PR but I'm not sure how to define all the 4 versions – if needed?

👋

kazupon commented 3 years ago

@afontcu Thank you for your feedback! :)

You’ve said, I also think that vue-i18n-jest should be supported for Vue 2 / Vue 3 and jest 26 / jest 27 like vue-jest.

Currently, vue-i18n-jest does not have a package/repo structure that takes for them. Maybe it should be a monorepo like vue-jest. :)

And, to support vue-i18n-jest for Vue 3, this PR needs to be merged. :) /cc @lmiller1990 https://github.com/vuejs/vue-jest/pull/364

kazupon commented 3 years ago

As my comment above, I want to support. However, I need help with this project as I am not working full-time. 🙏

If anyone is interested, please comment on this issue.

@nogic1008 You have previously contributed to vue-i18n-jest. If you are interested, I will give you permission to be a member of this intlify project. How about it?

@afontcu Of course, your contributions are welcome. :)

kazupon commented 3 years ago

I've just released v1.1.1 Please check it!

Thank you for your feedback! :)

You’ve said, I also think that vue-i18n-jest should be supported for Vue 2 / Vue 3 and jest 26 / jest 27 like vue-jest.

Currently, vue-i18n-jest does not have a package/repo structure that takes for them. Maybe it should be a monorepo like vue-jest. :)

I've opened it as a new issue. In About this, If it needs, we can discuss the below issue. https://github.com/intlify/vue-i18n-jest/issues/42

Thanks!