search

intracom-telecom-sdn / multinet

Large-scale SDN emulator based on Mininet
Eclipse Public License 1.0
15 stars 3 forks source link

Renamed multinet topologies name to be compatible with NSTAT #27

Closed konstantinos-papadopoulos closed 8 years ago

konstantinos-papadopoulos commented 8 years ago

NSTAT topology definition within the input json file is aligned now with Multinet and fully functional. A small change in the Multinet code has been committed so that NSTAT/Multinet are aligned as far as topology definition is concerned. See NSTAT commit id: regarding https://github.com/intracom-telecom-sdn/nstat/commit/6f0bd2aac52b14f759074a2fa8090c38709cd341

anastop commented 8 years ago

Although @georgepar is more responsible to handle this PR, my position here is that NSTAT should adapt to Multinet names and not the opposite.

georgepar commented 8 years ago

I agree with @anastop. Multinet is a framework to emulate arbitrary topologies, and thus should not be aware of the naming conventions in other tools. This results to unnecessary coupling between the projects and for most cases is impractical.

A more sane approach that will alter neither the Multinet or the NSTAT codebases is to create an adapter that sits between Multinet and NSTAT and performs the translation. This adapter should be a part of the tool using the Multinet framework, i.e. the NSTAT.

Given this we should not accept this pull request