intracom-telecom-sdn / nstat

Network Stress-Test Automation Toolkit
Eclipse Public License 1.0
13 stars 5 forks source link

topology_rest_server_stop handler #2

Open konstantinos-papadopoulos opened 8 years ago

konstantinos-papadopoulos commented 8 years ago

To be consistent with Multinet a conf key "topology_rest_server_stop" has been added which is not used at the moment when mininet is used as a generator. However, the mininet rest server stop takes place through stop_mininet_server() under mininet_utils.py. In Multinet this action is done by cleanup handler under /bin. I think we should be consistent in both cases since NSTAT treats both mininet and multinet as southbound generators. @panageo What do you think?

panageo commented 8 years ago

Mininet did not have a stop handler.

We could either create one and use it in mininet_utils or omit this parameter for mininet tests. You are right for consistency reasons we should create a stop handler and use it.

Best regards

On Wed, Jan 20, 2016 at 3:13 PM, Konstantinos Papadopoulos < notifications@github.com> wrote:

To be consistent with Multinet a conf key "topology_rest_server_stop" has been added which is not used at the moment when mininet is used as a generator. However, the mininet rest server stop takes place through stop_mininet_server() under mininet_utils.py. In Multinet this actions is done by cleanup handler under /bin. I think we should be consistent in both cases since NSTA treats both mininet and multinet as southbound generators. @panageo https://github.com/panageo What do you think?

— Reply to this email directly or view it on GitHub https://github.com/intracom-telecom-sdn/nstat/issues/2.

konstantinos-papadopoulos commented 8 years ago

At the moment conf key "topology_rest_server_stop" within sample json files

is cheated with the value './topology_custom_boot.py' which is not used at all.