oftraf miss count correctly when more than one openflow messages are encapsulated inside one tcp datagram

intracom-telecom-sdn / oftraf

pcap-based, RESTful OpenFlow traffic monitor

Eclipse Public License 1.0

6 stars 1 forks source link

oftraf miss count correctly when more than one openflow messages are encapsulated inside one tcp datagram #3

Closed panageo closed 8 years ago

panageo commented 8 years ago

oftraf counters do not count openflow messages when more than one openflow messages are encapsulated inside the data of one TCP datagram. For example if we have

TCP datagram
- type: OFPT_PACKET_OUT (13)
- type: OFPT_FLOW_MOD (14)
TCP datagram
- type: OFPT_FLOW_MOD (14)

then oftraf will fail to count the OFPT_FLOW_MOD that is encapsulated inside the first TCP datagram together with the OFPT_PACKET_OUT. It will only count the OFPT_PACKET_OUT

anastop commented 8 years ago

Yes, that's a bug. The whole TCP datagram needs to be checked for multiple OF packets, based on each OF packet's designated length (3rd field)