search

intrahealth / emNutt

mACM implementation for mHero
https://intrahealth.github.io/emNutt/
7 stars 3 forks source link

Restrict cancelling of schedules of messages already sent #63

Open lkwirica opened 3 years ago

lkwirica commented 3 years ago

image image

Related to issue #7

ashaban commented 3 years ago

@lkwirica can you give more details about this issue?

lkwirica commented 3 years ago

For integrity purposes, one can only cancel the record of a scheduled message BEFORE the message is sent out. Once the message has been sent, the record should not be deleted....This way, we can tell, all historical message schedules in the system

ashaban commented 3 years ago

@lkwirica This report only shows Active Schedules, Cancelling a schedule doesnt delete, it just deactivate. If you need a report of all scheduled messages we can then add a new report that list all scheduled messages (active and inactive), but not this one

cloehr651 commented 3 years ago

@lkwirica if you would like a new report please create a new issue that details what you want that report to include

lkwirica commented 3 years ago

@ashaban 'Active Schedule' in this case means a schedule whose message has been sent out/ not sent?

The schedules displayed are of messages already sent out....Shouldn't it then display schedules Not yet sent out? As in yet to be activated?

ashaban commented 3 years ago

Active Schedules is any schedule whose messages can still be sent out, remember that you can schedule a message to be sent out repeatedly i.e evey Monday and Tuesday, inactive schedule is the one that has either been cancelled or a schedule that can no longer be executed i.e you create a schedule to be executed twice in July, this schedule will be inactive in August. So the report is displaying active schedules to allow you to cancel any schedule you think it should not be executed or no longer needed to run.

lkwirica commented 3 years ago

image @ashaban Since the message was only to be sent out once, and the date passed, this should not be displaying on the 'Scheduled Messages' page...

ashaban commented 3 years ago

@lkwirica Yes, it should not, for now that feature is not supported, but you can still manually take them out by cancelling them. We will later add auto cancelling of schedules that has passed their time of execution, but this is not a priority for now since you can still manually cancel schedules.