intrepidcs / icsscand

User-mode SocketCAN daemon for Intrepid devices
BSD 2-Clause "Simplified" License
10 stars 6 forks source link

openDevices can be accessed by 2 threads at the same time #4

Closed tysonite closed 4 years ago

tysonite commented 4 years ago

Does it really safe to access openDevices w/o mutex used in searchForDevices()?

https://github.com/intrepidcs/icsscand/blob/a69c41c9d5df747b73bfcbfe9d0c4991949a0f76/src/main.cpp#L485

hollinsky-intrepid commented 4 years ago

This is fixed as of 8d21b98ac61e6ea5ecbc1e3ad8c6241ae531ff64 and release v2.0.3