search

intrepidcs / python_ics

Library for interfacing with Intrepid devices in Python
MIT License
61 stars 29 forks source link

Potentially copy-paste errors in object_neo_device.h #164

Closed grant-allan-ctct closed 8 months ago

grant-allan-ctct commented 9 months ago

Hello, this is my first day of looking at this project and my first experience with seeing a Python wrapper for C code, so I'm in danger of this being a silly question, or this Issue being the wrong way to ask it, but here goes: In object_neo_device.h there is a definition neo_device_object_members and to the untrained eye, certain items look like they may contain copy-paste errors.

Here is a link to the first of these lines of code on the master branch.

drebbe-intrepid commented 9 months ago
  • "AutoHandleClose" is given the same offset as "MaxAllowedClients"

This is a bug, for sure a copy and paste error. This has probably never worked correctly. Thanks for catching this!

  • "IsOpen" is given the same offset as "_Handle"
  • "IsOpen" is given the same help string as "_Handle"

This is a "work around" and really shouldn't be used at this point. Legacy stuff that was initially used but really shouldn't be now.

Here is a link to the first of these lines of code on the master branch.

drebbe-intrepid commented 8 months ago

Fixed, Will be in 913.