intrepidcs / python_ics

Library for interfacing with Intrepid devices in Python
MIT License
61 stars 29 forks source link

Confused ISO15765 API name #73

Closed keelung-yang closed 3 years ago

keelung-yang commented 4 years ago

iso15765_transmit_message() is used to transmit msg. iso15765_receive_message(), receive none of msg, but used to setup receiving msg.

So why not just _iso15765_setup_rxmsg() or more generic _setup_rxmsg(msg_type : iso15765/raw...) ?

drebbe-intrepid commented 3 years ago

I agree the name is confusing but its how the C API was written so its outside of the scope here.