search

intrepidcs / python_ics

Library for interfacing with Intrepid devices in Python
MIT License
61 stars 29 forks source link

Broken compatibility with libicsneo #96

Closed pierreluctg closed 3 years ago

pierreluctg commented 3 years ago

With the commit https://github.com/intrepidcs/python_ics/commit/f09909e70a23dff99a0b9a99c5a54c74c58b9239, the move to from icsneoOpenNeoDevice to icsneoOpenDevice the compatibility with libicsneolegacy.so is broken.

icsneoOpenDevice is not present in libicsneolegacy.so.

drebbe-intrepid commented 3 years ago

@pierreluctg Thanks for finding this. I'll try to create a fix for libicsneo next week sometime.

hollinsky-intrepid commented 3 years ago

We're all set here, thanks @drebbe-intrepid and @pierreluctg!

drebbe-intrepid commented 3 years ago

@pierreluctg I'll let you close this out, I did test this under Ubuntu with two vcan4.4s.

pierreluctg commented 3 years ago

Tested on Ubuntu 20.04

Thank you @drebbe-intrepid and @hollinsky-intrepid.