search

intridea / multi_json

A generic swappable back-end for JSON handling.
http://rdoc.info/projects/intridea/multi_json
MIT License
757 stars 129 forks source link

feat(ci): switch to github action #210

Closed BuonOmo closed 7 months ago

BuonOmo commented 7 months ago

@sferik json_pure tests are failing. I skept them as I don't understand what is the issue about. I think it is better to have tests like this to avoid further regressions and then look for the issue. I'll be less disponible next days, so here's a mergeable (IMHO) proposal

You'd have to activate Gihub Actions for the project, and branch protect master (and rename it ? <3)

sferik commented 7 months ago

Looks good! Thanks for the quick patch. I am able to create a main branch from master but I'm not able to change the default. Paging @intridea-shared to activate GitHub Actions and change the default branch!

sferik commented 7 months ago

Just merged this but noticed one more change that needs to be made: the build status badge in the README needs to be updated too.

Build Status

BuonOmo commented 7 months ago

EDIT: PR done here https://github.com/intridea/multi_json/pull/212

Arf I forgot it... Could you add it committing directly ?

main

[![CI](https://github.com/intridea/multi_json/workflows/Test/badge.svg)](https://github.com/intridea/_multijson/actions?query=workflow%3ATest+branch%3Amain+event%3Apush)

master

[![CI](https://github.com/intridea/multi_json/workflows/Test/badge.svg)](https://github.com/intridea/multi_json/actions?query=workflow%3ATest+branch%3Amaster+event%3Apush)

CI

I could do the PR once the branch is changed otherwise :)