search

intrig-unicamp / mininet-wifi

Emulator for Software-Defined Wireless Networks
https://mn-wifi.readthedocs.io/
Other
447 stars 241 forks source link

Add functionality to start SUMO simulation automatically #361

Closed awlane closed 3 years ago

awlane commented 3 years ago

This is a quick fix to add a parameter to the SUMO code to allow starting the simulation automatically (rather than manually) by passing the boolean argument start_on_run to net.useExternalProgram(). This should not break any existing code as without specifying it will just use the original behavior.

ramonfontes commented 3 years ago

What do you think about being more generic? Well, I mean, you could pass --start as an argument. Thus, we could you use more arguments supported by sumo in a more automatic way.

awlane commented 3 years ago

That could work in theory for sure. If we go that far, would we want to have default arguments at all or just a set of them?

ramonfontes commented 3 years ago

I think we can pass config_file, number of clients and port with default values and the rest with args and kwargs.

awlane commented 3 years ago

Sorry, I messed up my commit tree, will submit the change ASAP