intrig / xenon

The Intrig Message Decoder
MIT License
1 stars 6 forks source link

Error processing latest 36.331 e80 spec #16

Closed rgyger closed 5 years ago

rgyger commented 5 years ago

I'm trying to update the 36.331 asn doc to e80.

Steps performed: 1) export 36.331.doc rev e80 as text using MS Word 2) run asnstrip on the text and save as 36.331-e80.asn 3) remove all "-- ASN1STOP" and "-- ASN1START" blocks from asn file 4) update CMakeLists.txt file and rerun build.

The build is failing with the following error. The line 4253 comment was added by modifying asnast.h to output the error string to cerr before calling IT_PANIC()

[ 15%] Generating src/xenon/xddl/3GPP/TS-36.331.xddl opening src/xenon/xddl/asn/36.331/36.331-e80.asn finished module EUTRA-RRC-Definitions finished module PC5-RRC-Definitions finished module NBIOT-RRC-Definitions finished module EUTRA-UE-Variables finished module NBIOT-UE-Variables finished module EUTRA-Sidelink-Preconf finished module EUTRA-InterNodeDefinitions finished module NBIOT-InterNodeDefinitions parsing complete writing xddl line 4253: undefined instance for type 11BooleanType src/xenon/xddl/asn/36.331/36.331-e80.asn: [src/xenon/tools/asnx/asnast.h:137] make[2]: [src/xenon/xddl/3GPP/TS-36.331.xddl] Error 1 make[1]: [xenon/xddl/3GPP/36.331/CMakeFiles/36_331.dir/all] Error 2 make: *** [all] Error 2

rgyger commented 5 years ago

Looks like it's something introduced in rev 13 of the 36.331 spec.

Up to rev 12 passes. rev 13 fails with the 11BooleanType error.

wythe commented 5 years ago

@rgyger could you make a branch with your above change and push it to github and give me a link? I'm really a bit busy atm. Or just push to master.

rgyger commented 5 years ago

The only change is to add the following above line 136 of asnast.h:

    std::cerr << os.str() << std::endl;

I added it because IT_PANIC wasn't giving any info,

wythe commented 5 years ago

I'm talking about the updated xddl files you made from rev 13.

rgyger commented 5 years ago

no access?

On Mon, May 6, 2019 at 10:28 AM Mark Beckwith notifications@github.com wrote:

I'm talking about the updated xddl files you made from rev 13.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/intrig/xenon/issues/16#issuecomment-489663150, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUJP2PKQWQD6F7YMRXSC7DPUBFCHANCNFSM4HIGKNRQ .

wythe commented 5 years ago

You have to fork the xenon repo on github, clone it, add the updated files, and then push back to github. Then I can download it.

Here's the basic process: https://help.github.com/en/articles/fork-a-repo

rgyger commented 5 years ago

Ok. I’ve forked it and pushed the updated 36.331 asn file.

It’s under rgyger/xenon

On Mon, May 6, 2019 at 12:41 PM Mark Beckwith notifications@github.com wrote:

You have to fork the xenon repo on github, clone it, add the updated files, and then push back to github. Then I can download it.

Here's the basic process: https://help.github.com/en/articles/fork-a-repo

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/intrig/xenon/issues/16#issuecomment-489708499, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUJP2KO52Y6NHDXCRGKVN3PUBUTJANCNFSM4HIGKNRQ .

wythe commented 5 years ago

Ok thanks, I reproduced the error. Looking at it now.

wythe commented 5 years ago

@rgyger, I have this bug fixed and the r13 file upgraded on my personal fork (master). Please give it a shot: https://github.com/wythe/xenon.git

The intrig/xenon tree seems to be a bit behind. I made some updates a few years ago and didn't get them merged. So my @wythe tree is more accurate for now. I will update the intrig tree on my own time and let you know.

rgyger commented 5 years ago

Thanks. I’ll check it out.

On Sun, May 12, 2019 at 11:21 AM Mark Beckwith notifications@github.com wrote:

@rgyger https://github.com/rgyger, I have this bug fixed and the r13 file upgraded on my personal fork (master). Please give it a shot: https://github.com/wythe/xenon.git

The intrig/xenon tree seems to be a bit behind. I made some updates a few years ago and didn't get them merged. So my @wythe https://github.com/wythe tree is more accurate for now. I will update the intrig tree on my own time and let you know.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/intrig/xenon/issues/16#issuecomment-491609201, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUJP2PWEBESFGRQDDLVQGDPVA7W3ANCNFSM4HIGKNRQ .

rgyger commented 5 years ago

It’s working great. I even updated to the latest r14 spec and it’s working fine.

Thanks much.

On Sun, May 12, 2019 at 6:13 PM Richard Gyger rgyger@gmail.com wrote:

Thanks. I’ll check it out.

On Sun, May 12, 2019 at 11:21 AM Mark Beckwith notifications@github.com wrote:

@rgyger https://github.com/rgyger, I have this bug fixed and the r13 file upgraded on my personal fork (master). Please give it a shot: https://github.com/wythe/xenon.git

The intrig/xenon tree seems to be a bit behind. I made some updates a few years ago and didn't get them merged. So my @wythe https://github.com/wythe tree is more accurate for now. I will update the intrig tree on my own time and let you know.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/intrig/xenon/issues/16#issuecomment-491609201, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUJP2PWEBESFGRQDDLVQGDPVA7W3ANCNFSM4HIGKNRQ .

wythe commented 5 years ago

Fixed in #17.

Richard, you can can go back to using intrig/xenon as the upstream. I'll be making some additional improvements. You can see what I've done so far by looking at the closed Pull Requests.

If you like, you can submit a PR to get r14 into the master. Here is a nice guide if you are new to this process: https://gist.github.com/Chaser324/ce0505fbed06b947d962

rgyger commented 5 years ago

Thanks.

We’re actually looking at running with r15 now to get the 5g messaging.

On first run thru the compile it failed. I’ll know more when I another chance to look at it.

On Sat, Jul 6, 2019 at 8:15 AM Mark Beckwith notifications@github.com wrote:

Fixed in #17 https://github.com/intrig/xenon/pull/17.

Richard, you can can go back to using intrig/xenon as the upstream. I'll be making some additional improvements. You can see what I've done so far by looking at the closed Pull Requests.

If you like, you can submit a PR to get r14 into the master. Here is a nice guide if you are new to this process: https://gist.github.com/Chaser324/ce0505fbed06b947d962

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/intrig/xenon/issues/16?email_source=notifications&email_token=ABUJP2O3HBCM5HP7MSIGV3TP6CLFNA5CNFSM4HIGKNR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZKZOMY#issuecomment-508925747, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUJP2IVJR7RFPSHLNPYEA3P6CLFNANCNFSM4HIGKNRQ .

wythe commented 5 years ago

Ok great. I'll stay tuned. On Jul 6, 2019 8:57 AM, rgyger notifications@github.com wrote:Thanks.

We’re actually looking at running with r15 now to get the 5g messaging.

On first run thru the compile it failed. I’ll know more when I another

chance to look at it.

On Sat, Jul 6, 2019 at 8:15 AM Mark Beckwith notifications@github.com

wrote:

Fixed in #17 https://github.com/intrig/xenon/pull/17.

Richard, you can can go back to using intrig/xenon as the upstream. I'll

be making some additional improvements. You can see what I've done so far

by looking at the closed Pull Requests.

If you like, you can submit a PR to get r14 into the master. Here is a

nice guide if you are new to this process:

https://gist.github.com/Chaser324/ce0505fbed06b947d962

You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub

https://github.com/intrig/xenon/issues/16?email_source=notifications&email_token=ABUJP2O3HBCM5HP7MSIGV3TP6CLFNA5CNFSM4HIGKNR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZKZOMY#issuecomment-508925747,

or mute the thread

https://github.com/notifications/unsubscribe-auth/ABUJP2IVJR7RFPSHLNPYEA3P6CLFNANCNFSM4HIGKNRQ

.

—You are receiving this because you modified the open/close state.Reply to this email directly, view it on GitHub, or mute the thread.