Please find attached in this PR multiple enhancements for the Aws S3 Bucket tasks.
The add_objects_to_s3_entity helper method has been created which adds the objects which were found by various tasks to the AwsS3Bucket entity details.
Truth be told this could be done by creating an entity of the existing entity (as the details would be merged) however that seems to be a bit excessive due to the enrichment task running additional checks (such as verifying that the bucket exists, etc.) However if this is the agreed-upon way to go about this, we can modify so the enrichment task will only perform those respective checks if the entity detail is missing (aka new entity).
The AwsS3Bucketenrichment task has been refactored and updated to support the found_objects entity detail.
Lastly a bug has been fixed where @entity.save_changes was not called after hiding the entity causing it to not actually hide the entity.
Hi team,
Please find attached in this PR multiple enhancements for the
Aws S3 Buckettasks.The
add_objects_to_s3_entityhelper method has been created which adds the objects which were found by various tasks to theAwsS3Bucketentity details.Truth be told this could be done by creating an entity of the existing entity (as the details would be merged) however that seems to be a bit excessive due to the enrichment task running additional checks (such as verifying that the bucket exists, etc.) However if this is the agreed-upon way to go about this, we can modify so the enrichment task will only perform those respective checks if the entity detail is missing (aka new entity).
The
AwsS3Bucketenrichment task has been refactored and updated to support thefound_objectsentity detail.Lastly a bug has been fixed where
@entity.save_changeswas not called after hiding the entity causing it to not actually hide the entity.Final product:
Best regards, Maxim