intrigueio / intrigue-core

Discover Your Attack Surface!
https://core.intrigue.io
Other
1.36k stars 268 forks source link

adding new checks for open ports #423

Closed AnasBensalah closed 3 years ago

jcran commented 3 years ago

As-implemented, i dont think this will do much but create extra connections / delay. What's the backstory on the PR?

shpendk commented 3 years ago

@jcran You can read more details in this jira ticket, but the tldr is that we're creating networkservice entities without confirming the port is indeed open.

shpendk commented 3 years ago

The way this is implemented won't work. is_port_open is being called for udp but it only supports tcp, plus the web case is missing. Finally, the timeout implementation doesn't work with sidekiq (see here). This work needs to be redone.