intro-skipper / intro-skipper

Fingerprint audio to automatically detect and skip intro/credit sequences in Jellyfin
https://discord.gg/AYZ7RJ3BuA
GNU General Public License v3.0
770 stars 48 forks source link

Missing "Automatically skip Credits" #88

Closed mrld341 closed 7 months ago

mrld341 commented 7 months ago

I see "Automatically skip Intro" checkbox in plugin settings but don't see "Automatically skip Credits" or "Automatically press Next" So I assumed that this checkbox would apply to both (Into and Credits), but it doesn't seems to be the case.

Intro is getting skipped automatically, however end credits still require you to press or hover your mouse on to "Next" button.

Why have "Credit Detection" in scheduling tasks if there is no way to automatically skip it after it was detected?

Can somebody please advise how to make it work? I just need button "Next" to be clicked automatically when it pops out during credits.

I saw similar request in other places. But not for this plugin. Is there another plugin that needs to be added to make this work, or could current [intro-skipper] include that?

AbandonedCart commented 7 months ago

It should probably be a separate option.

mrld341 commented 7 months ago

@jumoog I see you mentioned this is another thread. What do you think, is adding "Automatically skip Credits" or "Automatically press Next" button is something you could possible do? Or that's is not something you looking to add to [intro-skipper] ?

phyzical commented 7 months ago

having a quick look at the code https://github.com/jumoog/intro-skipper/blob/10.9/preview/ConfusedPolarBear.Plugin.IntroSkipper/AutoSkip.cs

its not a simple "just add support for also credits" as it also makes a bunch of assumptions around being called at the start of the episodes.

Im not 100% sure how it knows to "start checking for a skip" do these just keep polling and the early exits avoid anything happening after the the skip/ when no intro to be skipped is detected?

i can probably have a crack at this though if @AbandonedCart or @jumoog know the answer to the above?

Though i wouldnt be suprised if it was designed this way for the most performant checks possible

mrld341 commented 7 months ago

@phyzical Did somebody figure it out or decided not to do this feature? I see you linked requested, but it says "Closed".

AbandonedCart commented 7 months ago

https://github.com/jumoog/intro-skipper/pull/103

mrld341 commented 7 months ago

@phyzical @AbandonedCart I tried to check #103 but it says that something is broken in new Jelly Fin version and now no work can be done on this?
Or is there another thread? Sorry I don't really understand how Github works with linking these random threads to each other.

Is there some rough version that just skips end credits without UI checkbox? I would test it if you advise on how to install such...

AbandonedCart commented 7 months ago

I thought that link was the work in progress.

phyzical commented 7 months ago

@mrld341 its forked off of the 10.9 source atm i think. but i have not been able to get the credits scan to work so i cant actually progress it atm.

AbandonedCart commented 7 months ago

It's currently added as a separate option. It still needs a lot of work internally, but it should be enough to consider the core issue resolved.

mrld341 commented 7 months ago

Tested it, seems to work most of the times. There is a bug, when you go through "recently viewed" episode, sometimes instead of going to the next episode on the list, it would go back to the menu. And message on a screen says "Intro skipped" instead of "credit skipped" However, when played through "Shows" - "Name of specific show" - "Season" - "episode X" . Always works and goes to next episode automatically 100% of the time. Thank you it's more than enough for me! Great plugin, Jellyfin should just integrate this one instead of re-doing everything from scratch for another 5 years...

AbandonedCart commented 7 months ago

You can change the message in the plugin settings. I believe I forgot to change the default from intro to credit. At least the copy paste mistake was something you can change, I guess.

mrld341 commented 7 months ago

You can change the message in the plugin settings. I believe I forgot to change the default from intro to credit. At least the copy paste mistake was something you can change, I guess.

Oh, you right, I didn't even realize you can expend "User Interface Customization" and there are things inside. That solves notification issue.

AbandonedCart commented 7 months ago

Glad to hear it. I also fixed the default. It never got changed. The cost of trying to save 30 seconds.

d8f6 commented 7 months ago

Feature is working great, thanks for this. I have a question and did not want to start a new issue: For the scheduled tasks do I need to do this order?:

  1. Detect\ Intros
  2. Detect\ Credits
  3. Detect\ Intros\ and\ Credits

Or is everything handled in the "Detect Intros and Credits" scheduled task now? I use jellyroller to automate all this from a script, just want to make sure I am doing it correctly/not wasting time with steps 1 and 2.

AbandonedCart commented 7 months ago

Last one covers everything and is the only one set to run (at midnight). The other two are there for special circumstances (you want intros now and you'll let the rest get handled overnight). That also pre-dated the automatic tasks getting cleaned up. Sadly, they don't provide a clear way to order them or the combined one would be first.

d8f6 commented 7 months ago

Understood. Thank you for the quick reply.

AbandonedCart commented 7 months ago

I imagine something like a debug setting on the configuration page to launch them from that would be ideal or at least I can add a note that it's optional extras.