search

intro-skipper / jellyfin-androidtv

Android TV Client for Jellyfin with Intro Skipper
GNU General Public License v2.0
3 stars 1 forks source link

binary blobs that are not verifiable #9

Closed jumoog closed 1 hour ago

jumoog commented 2 hours ago 
          Like I said, the **commit of the release** which links to https://github.com/intro-skipper/jellyfin-androidtv/commit/da4ce28b66bead099df97a0cf6a46db3d14dceb7. You're putting up binary blobs that are not verifiable.

Originally posted by @nielsvanvelzen in https://github.com/intro-skipper/intro-skipper/issues/325#issuecomment-2395544213

jumoog commented 2 hours ago

Like I said, the commit of the release which links to intro-skipper/jellyfin-androidtv@da4ce28. You're putting up binary blobs that are not verifiable.

Like I said, the commit of the release which links to intro-skipper/jellyfin-androidtv@da4ce28. You're putting up binary blobs that are not verifiable.

Actually, that's an inaccurate assumption. What happened is that the GitHub action modified the release binary, but not the release details due to an overlapping tag. A force push disconnected the hash listed from the hash of the actual commit.

I'm fixing the issue. Thanks for reporting it.

jumoog commented 2 hours ago

Sorry issue where off and I couldnt move it

AbandonedCart commented 1 hour ago

The softprops release action goes in a couple different directions. Apparently it amends the release, replaces the body, but leaves the original commit. So much for not needing to generate a bunch of tags...

AbandonedCart commented 1 hour ago

Seems to be working now.

@nielsvanvelzen You may want to confirm on your end just to be sure.

nielsvanvelzen commented 1 hour ago

Looks like the release now links to a valid commit. Thanks for picking it up that quickly!

As a sidenote; it does look like you're basing the releases on our master branch, which is always the development branch for the next release (0.18 in this case). I'd recommend using our release-xxx branches instead as those are stable. Our current master branch contains multiple known issues with playback (mostly related to recent subtitle changes).

AbandonedCart commented 1 hour ago

Looks like the release now links to a valid commit. Thanks for picking it up that quickly!

As a sidenote; it does look like you're basing the releases on our master branch, which is always the development branch for the next release (0.18 in this case). I'd recommend using our release-xxx branches instead as those are stable. Our current master branch contains multiple known issues with playback (mostly related to recent subtitle changes).

I don't typically use the softprops action and my tags are usually the hash, but now I'll have to see if they are aware of that issue.

This really isn't a long-term solution. It was a temporary stop-gap because @brewkunz threw together a way to get the button working and we offered to host it. I can rebase it for archival purposes, but there are no real plans to maintain it once 10.10 is released.

ExoPlayer 1.4.0 made subtitles fun for everyone.