search

intro-stat-learning / ISLP_labs

Up-to-date version of labs for ISLP
BSD 2-Clause "Simplified" License
660 stars 388 forks source link

Update Ch13-multiple-lab.ipynb #10

Closed saref closed 1 year ago

saref commented 1 year ago

I have fixed a minor error in the text description for re-sampling p-value in ch13 Jupyter file.

P-value is the fraction of the times that the test statistics obtained via re-sampling exceeds our observed test statistic (in absolute value).

It was written the other way around. The code correctly matches with the revised description.

jonathan-taylor commented 1 year ago

Yes, this is how that pvalue was computed (though 1-pvalue would still be a pvalue here as it's a two-sided test).

This repo is not the source for the labs, but will propose a change upstream to the source to correct. Hence, I will close, after having taken note of this. Thanks.