search

intro-stat-learning / ISLP_labs

Up-to-date version of labs for ISLP
BSD 2-Clause "Simplified" License
767 stars 442 forks source link

jupyterlap is missing from https://raw.githubusercontent.com/intro-stat-learning/ISLP_labs/v2.2/requirements.txt #28

Open lispercat opened 2 months ago

lispercat commented 2 months ago

Since in your readme you give instructions to run "jupyter lab ..." commands it would be a good idea to include jupyterlab in https://raw.githubusercontent.com/intro-stat-learning/ISLP_labs/v2.2/requirements.txt

tschm commented 2 months ago

Actually, I would advise against such a step. For the Docker image we use a standard Jupyter image and install all dependencies within. Often people would run our code on a central (university) server providing the actual lab. In this case it's easier to keep the requirements lean rather than installing a lab in a lab. If a separate installation of the jupyter lab is needed that should be a trivial additional pip install ...

lispercat commented 2 months ago

I see. Would it be possible to update the readme with some docker instructions?