search

intro2ddsp / intro2ddsp.github.io

A Jupyter book accompanying the ISMIR 2023 tutorial Introduction to DIfferentiable Audio Synthesiser Programming
54 stars 3 forks source link

Digital Synthesizer Modelling #4

Closed jorshi closed 11 months ago

jorshi commented 1 year ago

First draft on synthesizer modelling. The first three notebooks build up to a sound matching example with a harmonic synthesizer a la Engel.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] commented 12 months ago

View / edit / reply to this conversation on ReviewNB

dsuedholt commented on 2023-10-25T13:38:43Z ----------------------------------------------------------------


review-notebook-app[bot] commented 12 months ago

View / edit / reply to this conversation on ReviewNB

dsuedholt commented on 2023-10-25T13:38:45Z ----------------------------------------------------------------

  • technically, 1) sum to one was already introduced in the previous section - it made sense to introduce it there, could maybe here just clarify that we're using a harmonic synthesizer with the following additions
  • we'll use [a] frame rate of 100Hz
  • dimensionality - typo


jorshi commented on 2023-10-30T09:11:36Z ----------------------------------------------------------------

Great point - updated.

review-notebook-app[bot] commented 12 months ago

View / edit / reply to this conversation on ReviewNB

dsuedholt commented on 2023-10-25T13:38:46Z ----------------------------------------------------------------

  • is [a] scalling funciton


review-notebook-app[bot] commented 12 months ago

View / edit / reply to this conversation on ReviewNB

dsuedholt commented on 2023-10-25T13:38:47Z ----------------------------------------------------------------

  • double "applies"


review-notebook-app[bot] commented 12 months ago

View / edit / reply to this conversation on ReviewNB

dsuedholt commented on 2023-10-25T13:38:48Z ----------------------------------------------------------------

  • frequency typo


review-notebook-app[bot] commented 12 months ago

View / edit / reply to this conversation on ReviewNB

dsuedholt commented on 2023-10-25T13:38:49Z ----------------------------------------------------------------

  • that [are] time-varying
  • double "using"


review-notebook-app[bot] commented 12 months ago

View / edit / reply to this conversation on ReviewNB

dsuedholt commented on 2023-10-25T13:38:50Z ----------------------------------------------------------------

  • frquency typo


review-notebook-app[bot] commented 12 months ago

View / edit / reply to this conversation on ReviewNB

dsuedholt commented on 2023-10-25T13:38:51Z ----------------------------------------------------------------

  • "fundemental" typo
  • Could potentially mention that the harmonic model is not well-suited for transient attack sounds?


jorshi commented on 2023-10-30T09:12:39Z ----------------------------------------------------------------

I added a brief discussion on transient attack sounds in the next section

jorshi commented 11 months ago

Great point - updated.

View entire conversation on ReviewNB

jorshi commented 11 months ago

I added a brief discussion on transient attack sounds in the next section

View entire conversation on ReviewNB

jorshi commented 11 months ago

@dsuedholt -- updated based on your review comments, thank you for those.

In addition to updating the main jupyter notebooks, I've now finished the introduction markdown, a page showing examples/discussion of the harmonic synthesis with different instruments, and a page with a few differentiable synthesis libraries. This should be good now for this portion of the book.

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.