search

introlab / find-object

Find-Object project
http://introlab.github.io/find-object/
BSD 3-Clause "New" or "Revised" License
448 stars 189 forks source link

buildtool depend on genmsg? #83

Closed gavanderhoorn closed 5 years ago

gavanderhoorn commented 5 years ago

Looking at the package manifest of this package I noticed that it expresses a buildtool_depend on genmsg (here).

The build script doesn't seem to do anything special wrt messages/services or actions, so I'm wondering whether that dependency is really needed. If it was added to be able to build messages, it should not be needed (message_runtime and message_generation are responsible pulling in the required dependencies).

matlabbe commented 5 years ago

It used for generating custom messages: https://github.com/introlab/find-object/blob/ef0c565b7e3b3a3e78ae5424a7536cf3dd3e9101/CMakeLists.txt#L295-L300

Indeed, based on this tutorial:

Open package.xml, and make sure these two lines are in it and uncommented:

message_generation message_runtime

I did the changes in this commit. Note that to avoid this error (tested on Kinetic):

$ catkin_make
Base path: /home/labm2414/catkin_ws
Source space: /home/labm2414/catkin_ws/src
Build space: /home/labm2414/catkin_ws/build
Devel space: /home/labm2414/catkin_ws/devel
Install space: /home/labm2414/catkin_ws/install
Error(s) in package '/home/labm2414/catkin_ws/src/find-object/package.xml':
Error(s):
- The manifest (with format version 1) must not contain the following tags: exec_depend

I replaced exec_depend by run_depend instead.

cheers, Mathieu

gavanderhoorn commented 5 years ago

@matlabbe wrote:

It used for generating custom messages [..]

5047163c already changed it, but genmsg is not needed for message generation. message_generation and message_runtime pull the necessary dependencies in for that.

Thanks for fixing this.