search

introlab / irl_audio

A fork of IntRoLab's original ROS packages for ManyEars
6 stars 10 forks source link

irl_audio meta package? #5

Open elaske opened 7 years ago

elaske commented 7 years ago

There is not a meta package (maybe irl_audio?) for all the packages included in this repo. Once those above were fixed, building manyears_ros would only build 3 packages.

audio_tools does not build (which maybe it shouldn't because it's not required, but maybe better to split off?)

francoisferland commented 7 years ago

audio_tools does not build (which maybe it shouldn't because it's not required, but maybe better to split off?)

That package contains a set of tools that can be useful when dealing with sources that require resampling or pre-recorded audio sequences. However, they are not necessary to run a "normal" ManyEars/8Sounds setup, so that's why they are not automatically built.

I agree with the meta package suggestion.

elaske commented 7 years ago

Maybe that's a justification to split them off into their own repository under introlab? Just a thought.

francoisferland commented 7 years ago

Now that I think about it, the Kinect demo setup relies on the upscaler in audio_tools, that's probably why we included it there. So that's another missing dependency.

The whole package would benefit from an overhaul / better integration with the latest repo/version of the library (issue #3). I no longer manage that repository, but I would be happy to assist!

elaske commented 7 years ago

@doumdi should be aware of all these issues - I asked him to enable to issue tracker on this repo for this ;). He says he wants to clean up the repos by 2017.

@francoisferland: I'll put in an issue / feature request to package the manyears core as well.