search

introlab / rtabmap

RTAB-Map library and standalone application
https://introlab.github.io/rtabmap
Other
2.75k stars 785 forks source link

SIFT not availble with only free version OpenCV 4.4.0 #596

Open seanxu112 opened 4 years ago

seanxu112 commented 4 years ago

Hi Mathieu,

It seems like in guilib/src/PreferencesDialog.cpp you are still checking whether the Kp/DetectorStrategy to be <=1 which includes SIFT.

Since in 4.4.0 version SIFT is no longer in non-free modules, I keep getting the error: PreferencesDialog.cpp:4180::setParameter() Trying to set "Kp/DetectorStrategy" to SURF but RTAB-Map isn't built with the nonfree module from OpenCV. Keeping default combo value: GFTT+BRIEF.

I changed it to strictly < 1 and it works fine now, but just want to let you know.

Sincerely, Sean Xu

matlabbe commented 4 years ago

Hi, thx to point out! I updated the code to still have the warning for older opencv versions. See commit above.

cheers, Mathieu