Closed Tobias-Fischer closed 9 years ago
I've merged with a little change for Qt4 on QPrinter include. I noticed that QT5_USE_MODULES is not set in some tools, is it because it was called on the rtabmap_gui target so we don't have to set it again on projects depending on rtabmap_gui? I can't test on Qt5 for now.
Hi @matlabbe, Thanks for the quick merge! That will be useful for me, as I don't have to hold a separate version which I have to keep updated. I'll make sure to fix any issues related to Qt5.
Regarding your questions:
1) Yes, I was surprised myself that I don't have to set QT5_USE_MODULES for the tools. However, it works nicely for me - probably due to the link to rtabmap_gui. If you consider it to be more clean, feel free to add it in the tools/examples though.
2) Actually, the #if / #elseif
is not needed. #include <QPrinter>
works nicely due to QT5_USE_MODULES(rtabmap ... PrintSupport)
in QT5 as well. I did not know about this at first, so I changed it to #include <QtPrintSupport/QPrinter>
and forgot to change it back. Sorry for that, would you mind fixing it in one of the next commits?
Thanks again! Tobias
Oh, and by the way, I messed up your .gitignore
in ./build
. Sorry for that! I find it much cleaner to ignore the whole folder rather than individual files in the folder, so I added ./build
in my local git exclude ...
Great, thanks!
Hi,
I want to use rtabmap with Qt5, and this pull request contains the changes which are needed to get it running under Ubuntu. I know that this definitely needs more work to generalize to Windows and Mac, however I am not using either of those platforms.
What I changed is:
Please note that PCL as well as VTK have to be compiled with Qt5 (see http://www.vtk.org/Wiki/VTK/Configure_and_Build#Qt5..2A)
Some issues which might arise:
Please let me know whether you find this contribution useful, and what changes you want me to make to merge it to the main repository. For the beginning, it would be good to know whether something is broken when using Qt4 (I cannot/don't want to test it, as I would need to recompile VTK+PCL ..)
Best, Tobias