introocean / introocean-en

Introduction to Physical Oceanography by R. Stewart
Other
67 stars 10 forks source link

Name the artifact with the tag #8

Closed ocefpaf closed 1 year ago

ocefpaf commented 2 years ago

Let's see if this works. Addresses https://github.com/introocean/introocean-en/pull/7#issuecomment-1260084090 from @sergeykorop.

ocefpaf commented 2 years ago

It will still have a generic name "book" on PR artifacts but those should be used only to check the build. When tagging the pdf will be named tag-name.pdf. You can see a test in my fork in https://github.com/ocefpaf/introocean-en/releases/tag/v20220922

koldunovn commented 1 year ago

Is it ready to be merged?

ocefpaf commented 1 year ago

Is it ready to be merged?

IMO, yes.