Closed GoogleCodeExporter closed 9 years ago
Hi.
Yes, it will fix the issue.
Some comments regarding the changes:
- Better to check if the port is the default port for the used scheme instead of only checking if it's a default port (of any scheme). The port 80 should be shown when it's used for scheme "https" (the same for port 443 but with scheme "http").
- Consider to extract a method from the creation of the "host" representation.
Best regards.
Original comment by THC...@gmail.com
on 25 Feb 2013 at 4:56
Hi,
Thanks for testing) I do agree with both point, so I'll update the code
according to your suggestions and will commit it to trunk.
Cheers,
Sergey
Original comment by serge....@gmail.com
on 25 Feb 2013 at 8:32
Hi.
OK. Sounds good to me.
Best regards.
Original comment by THC...@gmail.com
on 25 Feb 2013 at 5:39
Committed changes:
https://code.google.com/p/zaproxy/source/detail?r=2921
Original comment by serge....@gmail.com
on 26 Feb 2013 at 1:27
Original comment by serge....@gmail.com
on 27 Feb 2013 at 11:38
Original comment by psii...@gmail.com
on 4 Mar 2013 at 9:16
The fix doesn't properly handle non-80 and non-443 ports, treating them like
default ones for specified protocol.
Original comment by serge....@gmail.com
on 11 Mar 2013 at 1:44
Committed:
https://code.google.com/p/zaproxy/source/detail?r=2964
Original comment by serge....@gmail.com
on 11 Mar 2013 at 1:47
Fixed in 2.1.0
Original comment by psii...@gmail.com
on 18 Apr 2013 at 9:49
Original issue reported on code.google.com by
serge....@gmail.com
on 22 Feb 2013 at 8:57Attachments: