Improve the code handling OData according to the review done by thc202.
- Consider to create a helper class that contains the OData patterns used (or,
even better, helper parser methods), so those patterns don't need to be
duplicated in several classes.
- Better use of the matchers
Example for VariantODataFilterQuery.java
- On the lines 89 and 90, consider to replace the calculation of the "begin" and "end" with calls to the methods Matcher.start(int) ("matcher.start(1)") and Matcher.end(int) ("matcher.end(1)") respectively;
- On the lines 106 and 107, consider to replace the calculation of the "begin" and "end" with calls to the methods Matcher.start() ("matcherParameters.start()") and Matcher.end() ("matcherParameters.end()") respectively;
Original issue reported on code.google.com by patrick....@gmail.com on 27 Mar 2013 at 5:10
Original issue reported on code.google.com by
patrick....@gmail.comon 27 Mar 2013 at 5:10